[Fwd: Re: Re: [PATCH] Initial support for Neuros OSD2 platform.]

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[Fwd: Re: Re: [PATCH] Initial support for Neuros OSD2 platform.]

A. Porodko

Kevin Hilman wrote:
> Andrey Porodko <[hidden email]> writes:
>
>  
> Still has checkpatch problems.  I know you inherited some of them from
> dm644x, but they should still be fixed.
>
>  
Hello,

Reworked and sent patch again. Now I don't have nor error, nor warinings
with
checkpatch.pl script. Patch generated exactly against your repo.
-------cut---------
andy@Black:~/OSD2-NG/linux-davinci$ scripts/checkpatch.pl
0001-Initial-support-for-Neuros-OSD2-platform.patch
total: 0 errors, 0 warnings, 348 lines checked

0001-Initial-support-for-Neuros-OSD2-platform.patch has no obvious style
problems and is ready for submission.
---------cut------------

>> +static void __init ntosd2_init_i2c(void)
>> +{
>> + davinci_init_i2c(&ntosd2_i2c_pdata);
>> + gpio_request(NTOSD2_MSP430_IRQ, ntosd2_i2c_info[0].type);
>> + gpio_direction_input(NTOSD2_MSP430_IRQ);
>> + ntosd2_i2c_info[0].irq =pio_to_irq(NTOSD2_MSP430_IRQ);
>> + i2c_register_board_info(1, ntosd2_i2c_info, ARRAY_SIZE(ntosd2_i2c_info));
>>    
>
> Many of these functions have return values that should be checked for
> errors.
>
>  
Can this be done in the next patch?
>>    


--
Best regards
Andrey A. Porodko
 




--
Best regards
Andrey A. Porodko