[PATCH] DaVinci: DM365: Remove #ifdef from board file to load RTC as a module properly

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] DaVinci: DM365: Remove #ifdef from board file to load RTC as a module properly

miguel.aguilar@ridgerun.com
From: Miguel Aguilar <[hidden email]>

Remove the #ifdef of the dm365_rtc_init function from the DM365 board
file in order to load the davinci rtc driver as a module properly.

Signed-off-by: Miguel Aguilar <[hidden email]>
---
 arch/arm/mach-davinci/board-dm365-evm.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mach-davinci/board-dm365-evm.c b/arch/arm/mach-davinci/board-dm365-evm.c
index ad0cb3f..8d23972 100644
--- a/arch/arm/mach-davinci/board-dm365-evm.c
+++ b/arch/arm/mach-davinci/board-dm365-evm.c
@@ -513,14 +513,11 @@ static __init void dm365_evm_init(void)
  evm_init_cpld();
 
  dm365_init_asp(&dm365_evm_snd_data);
+ dm365_init_rtc();
 
 #ifdef CONFIG_KEYBOARD_DAVINCI
  dm365_init_ks(&dm365evm_ks_data);
 #endif
-
-#ifdef CONFIG_RTC_DRV_DAVINCI
- dm365_init_rtc();
-#endif
 }
 
 static __init void dm365_evm_irq_init(void)
--
1.6.0.4


Reply | Threaded
Open this post in threaded view
|

[PATCH] DaVinci: DM365: Remove #ifdef from board file to load RTC as a module properly

Kevin Hilman
<[hidden email]> writes:

> From: Miguel Aguilar <[hidden email]>
>
> Remove the #ifdef of the dm365_rtc_init function from the DM365 board
> file in order to load the davinci rtc driver as a module properly.
>
> Signed-off-by: Miguel Aguilar <[hidden email]>

Thanks, will fold this one into original RTC patch before pushing upstream.

Please coordinate with Sneha on how to remove the keypad one using
platform_data callback hooks as she proposed.

Kevin

> ---
>  arch/arm/mach-davinci/board-dm365-evm.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-dm365-evm.c b/arch/arm/mach-davinci/board-dm365-evm.c
> index ad0cb3f..8d23972 100644
> --- a/arch/arm/mach-davinci/board-dm365-evm.c
> +++ b/arch/arm/mach-davinci/board-dm365-evm.c
> @@ -513,14 +513,11 @@ static __init void dm365_evm_init(void)
>   evm_init_cpld();
>  
>   dm365_init_asp(&dm365_evm_snd_data);
> + dm365_init_rtc();
>  
>  #ifdef CONFIG_KEYBOARD_DAVINCI
>   dm365_init_ks(&dm365evm_ks_data);
>  #endif
> -
> -#ifdef CONFIG_RTC_DRV_DAVINCI
> - dm365_init_rtc();
> -#endif
>  }
>  
>  static __init void dm365_evm_irq_init(void)
> --
> 1.6.0.4
>
>
> _______________________________________________
> Davinci-linux-open-source mailing list
> [hidden email]
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply | Threaded
Open this post in threaded view
|

[PATCH] DaVinci: DM365: Remove #ifdef from board file to load RTC as a module properly

miguel.aguilar@ridgerun.com
Kevin,

I'm about to send the patch for the DaVinci Keyscan.

Thanks,

Miguel Aguilar
Kevin Hilman wrote:

> <[hidden email]> writes:
>
>> From: Miguel Aguilar <[hidden email]>
>>
>> Remove the #ifdef of the dm365_rtc_init function from the DM365 board
>> file in order to load the davinci rtc driver as a module properly.
>>
>> Signed-off-by: Miguel Aguilar <[hidden email]>
>
> Thanks, will fold this one into original RTC patch before pushing upstream.
>
> Please coordinate with Sneha on how to remove the keypad one using
> platform_data callback hooks as she proposed.
>
> Kevin
>
>> ---
>>  arch/arm/mach-davinci/board-dm365-evm.c |    5 +----
>>  1 files changed, 1 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/mach-davinci/board-dm365-evm.c b/arch/arm/mach-davinci/board-dm365-evm.c
>> index ad0cb3f..8d23972 100644
>> --- a/arch/arm/mach-davinci/board-dm365-evm.c
>> +++ b/arch/arm/mach-davinci/board-dm365-evm.c
>> @@ -513,14 +513,11 @@ static __init void dm365_evm_init(void)
>>   evm_init_cpld();
>>  
>>   dm365_init_asp(&dm365_evm_snd_data);
>> + dm365_init_rtc();
>>  
>>  #ifdef CONFIG_KEYBOARD_DAVINCI
>>   dm365_init_ks(&dm365evm_ks_data);
>>  #endif
>> -
>> -#ifdef CONFIG_RTC_DRV_DAVINCI
>> - dm365_init_rtc();
>> -#endif
>>  }
>>  
>>  static __init void dm365_evm_irq_init(void)
>> --
>> 1.6.0.4
>>
>>
>> _______________________________________________
>> Davinci-linux-open-source mailing list
>> [hidden email]
>> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source