[PATCH] breadcrumb root

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] breadcrumb root

Klaas Freitag
Hi,

I am sending a patch that adds the root element to the breadcrumb line.
Instead of
a > b > c
with the patch is looks like
/ > a > b > c

For me that would look more natural, I ask you to consider.

I apologise to sending a patch to ML rather doing it through reviewboard, I
havent worked through the workflow documentation yet.

regards,

Klaas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: breadcrumb.dif
Type: text/x-patch
Size: 2180 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/owncloud/attachments/20110731/44ed11c0/attachment.diff 

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] breadcrumb root

Jan-Christoph Borchardt-2
Hello Klaas,

for the moment, I?d say don?t add this. We explicitly left that out because
a) people don?t think of "/" and shouldn?t be exposed to it unnecessarily
b) because clicking "Files" already gets you to the main folder, making it
redundant.

That said, I will do usability tests with the current design and let you
know how it fares.

(Also, sending in patches over the mailing list is perfectly fine. :)


On Sun, July 31, 2011 21:33, Klaas Freitag wrote:

> Hi,
>
> I am sending a patch that adds the root element to the breadcrumb line.
> Instead of
> a > b > c
> with the patch is looks like
> / > a > b > c
>
> For me that would look more natural, I ask you to consider.
>
> I apologise to sending a patch to ML rather doing it through reviewboard,
> I
> havent worked through the workflow documentation yet.
>
> regards,
>
> Klaas
> _______________________________________________
> Owncloud mailing list
> Owncloud at kde.org
> https://mail.kde.org/mailman/listinfo/owncloud
>



Reply | Threaded
Open this post in threaded view
|

[PATCH] breadcrumb root

Klaas Freitag
Am 31.07.2011 21:47, schrieb Jan-Christoph Borchardt:
> Hello Klaas,
>
> for the moment, I?d say don?t add this. We explicitly left that out because
> a) people don?t think of "/" and shouldn?t be exposed to it unnecessarily
> b) because clicking "Files" already gets you to the main folder, making it
> redundant.
Yeah, I kind of expected that. For me however, the breadcrumbs look
incomplete, as
you cant switch back to start. The Files button is fine, but it would be
even better if it
had more visible connection to the breadcrumb list. Do you think thats
doable?

Klaas



Reply | Threaded
Open this post in threaded view
|

[PATCH] breadcrumb root

Jan-Christoph Borchardt-2
Hey Klaas,

On Tue, August 2, 2011 15:32, Klaas Freitag wrote:
> The Files button is fine, but it would be even better if it
> had more visible connection to the breadcrumb list. Do you think thats
> doable?

Actually that was intended in the mockups and was in the code already ?
only not working properly. I pushed a fix for that last night. :)

https://projects.kde.org/projects/playground/www/owncloud/repository/revisions/b5c213ce6dad6cec98fd337e0458a370ad4b0869

git pull and let me know if that?s good.


Reply | Threaded
Open this post in threaded view
|

[PATCH] breadcrumb root

Klaas Freitag
Am 02.08.2011 15:58, schrieb Jan-Christoph Borchardt:
>
> Actually that was intended in the mockups and was in the code already ?
> only not working properly. I pushed a fix for that last night. :)
>
> https://projects.kde.org/projects/playground/www/owncloud/repository/revisions/b5c213ce6dad6cec98fd337e0458a370ad4b0869
>
> git pull and let me know if that?s good.
Thats great. Fixes the issue for me, thanks :-)

Klaas