[PATCH v3 1/5] davinci: DA830/OMAP-L137 EVM: use runtime detection for UI card

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH v3 1/5] davinci: DA830/OMAP-L137 EVM: use runtime detection for UI card

Kevin Hilman
Sekhar Nori <[hidden email]> writes:

> This patch supports runtime detection of DA830 UI card and
> eliminates the need for DA830_UI config option. Successful
> probe of GPIO expander present on the UI card is used to
> detect its presence. For this reason, GPIO_PCF857X is auto-
> selected when DA830 EVM is configured. In case the UI card
> is absent, the probe fails in reasonable time.
>
> As a side effect this patch also gets rid of the voilation
> of Documentation/SubmittingPatches section 2.2 in function
> da830_evm_ui_expander_setup()
>
> Signed-off-by: Sekhar Nori <[hidden email]>

Looks great, thanks.

One comment/question below.

[...]

> +static int da830_evm_ui_expander_setup(struct i2c_client *client, int gpio,
> + unsigned ngpio, void *context)
> +{
> + gpio_request(gpio + 6, "MUX_MODE");

This name isn't very descripitve when seen in debugfs.  Would "UI mux mode"
be more appropriate?  If not, please suggest something else and I'll
update before committing.

Thanks,

Kevin

Reply | Threaded
Open this post in threaded view
|

[PATCH v3 1/5] davinci: DA830/OMAP-L137 EVM: use runtime detection for UI card

Nori, Sekhar
On Tue, Nov 03, 2009 at 00:31:41, Kevin Hilman wrote:

> Sekhar Nori <[hidden email]> writes:
>
> > This patch supports runtime detection of DA830 UI card and
> > eliminates the need for DA830_UI config option. Successful
> > probe of GPIO expander present on the UI card is used to
> > detect its presence. For this reason, GPIO_PCF857X is auto-
> > selected when DA830 EVM is configured. In case the UI card
> > is absent, the probe fails in reasonable time.
> >
> > As a side effect this patch also gets rid of the voilation
> > of Documentation/SubmittingPatches section 2.2 in function
> > da830_evm_ui_expander_setup()
> >
> > Signed-off-by: Sekhar Nori <[hidden email]>
>
> Looks great, thanks.
>
> One comment/question below.
>
> [...]
>
> > +static int da830_evm_ui_expander_setup(struct i2c_client *client, int gpio,
> > +           unsigned ngpio, void *context)
> > +{
> > +   gpio_request(gpio + 6, "MUX_MODE");
>
> This name isn't very descripitve when seen in debugfs.  Would "UI mux mode"
> be more appropriate?  If not, please suggest something else and I'll
> update before committing.

The name is coming from a signal name in the UI card schematics.
The signal is actually called "MUX_MODE" so, "UI mux_mode" seems
appropriate to me.

Thanks,
Sekhar

Reply | Threaded
Open this post in threaded view
|

[PATCH v3 1/5] davinci: DA830/OMAP-L137 EVM: use runtime detection for UI card

Kevin Hilman
"Nori, Sekhar" <[hidden email]> writes:

> On Tue, Nov 03, 2009 at 00:31:41, Kevin Hilman wrote:
>> Sekhar Nori <[hidden email]> writes:
>>
>> > This patch supports runtime detection of DA830 UI card and
>> > eliminates the need for DA830_UI config option. Successful
>> > probe of GPIO expander present on the UI card is used to
>> > detect its presence. For this reason, GPIO_PCF857X is auto-
>> > selected when DA830 EVM is configured. In case the UI card
>> > is absent, the probe fails in reasonable time.
>> >
>> > As a side effect this patch also gets rid of the voilation
>> > of Documentation/SubmittingPatches section 2.2 in function
>> > da830_evm_ui_expander_setup()
>> >
>> > Signed-off-by: Sekhar Nori <[hidden email]>
>>
>> Looks great, thanks.
>>
>> One comment/question below.
>>
>> [...]
>>
>> > +static int da830_evm_ui_expander_setup(struct i2c_client *client, int gpio,
>> > +           unsigned ngpio, void *context)
>> > +{
>> > +   gpio_request(gpio + 6, "MUX_MODE");
>>
>> This name isn't very descripitve when seen in debugfs.  Would "UI mux mode"
>> be more appropriate?  If not, please suggest something else and I'll
>> update before committing.
>
> The name is coming from a signal name in the UI card schematics.
> The signal is actually called "MUX_MODE" so, "UI mux_mode" seems
> appropriate to me.

OK, will make this small change before pushing.

Thanks,

Kevin