owncloud-client is has now reproducible build on debian

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

owncloud-client is has now reproducible build on debian

Hefee
Hey,

At DebConf I sit down with the guys that push the emforcement of reproducible
builds and fixed the last issues for owncloud-client [0]. Reproducible build
means that you are able to recompile and the outcome is bit by bit the same.
With that you know, that the build is really made from the source.

I added a patch [1] and need to run optipng on all images before it was
reproducible. The patch is not needed anymore if gcc is patched properly but I
wanted you inform about that success and maybe other want to ship a
reproducible owncloud-client.

Regards,

sandro

PS: the reproducible infrastructure using at the moment many patches on
verious programs (gcc, latex), so it is not a "clean" debian system, but it is
tried hard to push the patches upstream.

[0] https://reproducible.debian.net/rb-pkg/experimental/amd64/owncloud-client.html

[1] http://anonscm.debian.org/cgit/pkg-owncloud/owncloud-client.git/tree/debian/patches/0008-make-reproducable.patch
_______________________________________________
Devel mailing list
[hidden email]
http://mailman.owncloud.org/mailman/listinfo/devel
Reply | Threaded
Open this post in threaded view
|

Re: owncloud-client is has now reproducible build on debian

Klaas Freitag-3
On 25.08.2015 10:42, Hefee wrote:
Hi Sandro,

>
> At DebConf I sit down with the guys that push the emforcement of reproducible
> builds and fixed the last issues for owncloud-client [0]. Reproducible build
> means that you are able to recompile and the outcome is bit by bit the same.
> With that you know, that the build is really made from the source.

That is great news, thanks for working on that!

>
> I added a patch [1] and need to run optipng on all images before it was
> reproducible. The patch is not needed anymore if gcc is patched properly but I
> wanted you inform about that success and maybe other want to ship a
> reproducible owncloud-client.

About patch [1]: Wouldn't it have been enough to remove the date and
time reference from the string, rather than returning an empty string?

This git sha info has turned out to be useful when debugging...

regards,

Klaas

>


_______________________________________________
Devel mailing list
[hidden email]
http://mailman.owncloud.org/mailman/listinfo/devel
Reply | Threaded
Open this post in threaded view
|

Re: owncloud-client is has now reproducible build on debian

Hefee
Hey,

> About patch [1]: Wouldn't it have been enough to remove the date and
> time reference from the string, rather than returning an empty string?

Yes that would be enough. But the reproducible team in debian is pushing hard
to get a patch into gcc to be able to controle the time,date from the outside,
than the patch wouldn't be needed at all.

> This git sha info has turned out to be useful when debugging...

It is not (that) usefull for us. We have a debian version that actually points
to one git tag. Every version that lands on debian has a git tag so there is
not additional information in the git sha. It is already patched, that we show
the debian version and not the upstream version. I see no advatage to show the
git sha, that does not working for us, because we use git also packaging and
the git sha, that is shown is a git sha of the
http://anonscm.debian.org/cgit/pkg-owncloud/owncloud-client.git repo). I tried
it alrealy multiple time to point to the correct git sha of upstream - but had
no luck :(
These were the two resons that made me to delete the complete part.

I know it is only true for debian, for upstream and people that compile from
scratch, the git sha can be usefull.

Regards,

sandro
_______________________________________________
Devel mailing list
[hidden email]
http://mailman.owncloud.org/mailman/listinfo/devel
Reply | Threaded
Open this post in threaded view
|

Re: owncloud-client is has now reproducible build on debian

Sebastian Kügler
On Wednesday, August 26, 2015 18:59:41 Hefee wrote:

> > About patch [1]: Wouldn't it have been enough to remove the date and
> > time reference from the string, rather than returning an empty string?
>
> Yes that would be enough. But the reproducible team in debian is pushing
> hard to get a patch into gcc to be able to controle the time,date from the
> outside, than the patch wouldn't be needed at all.
>
> > This git sha info has turned out to be useful when debugging...
>
> It is not (that) usefull for us. We have a debian version that actually
> points to one git tag. Every version that lands on debian has a git tag so
> there is not additional information in the git sha. It is already patched,
> that we show the debian version and not the upstream version. I see no
> advatage to show the git sha, that does not working for us, because we use
> git also packaging and the git sha, that is shown is a git sha of the
> http://anonscm.debian.org/cgit/pkg-owncloud/owncloud-client.git repo). I
> tried it alrealy multiple time to point to the correct git sha of upstream
> - but had no luck :(
> These were the two resons that made me to delete the complete part.

Puzzled: The git sha is the same for every build of exactly that state of the
owncloud repo.

The problem may well be this, since it introduces another var into the SHA:
-            .arg(__DATE__).arg(__TIME__)

> I know it is only true for debian, for upstream and people that compile from
> scratch, the git sha can be usefull.
--
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
_______________________________________________
Devel mailing list
[hidden email]
http://mailman.owncloud.org/mailman/listinfo/devel
Reply | Threaded
Open this post in threaded view
|

Re: owncloud-client is has now reproducible build on debian

Hefee
Hey,

> Puzzled: The git sha is the same for every build of exactly that state of
> the owncloud repo.

the problem here is that the .tag is controlled by the debian repo. so f.ex.
the sha1 that is shown is 74e265339244766c8eb180026514b608399b8bc4, that is
not a valid id in the upstream repo but in the debian repo:
http://anonscm.debian.org/cgit/pkg-owncloud/owncloud-client.git

this has nothing to do with the reporducible builds.

> The problem may well be this, since it introduces another var into the SHA:
> -            .arg(__DATE__).arg(__TIME__)

as i explained before - this is the problematic line in terms of reproducible
builds (at the moment). I only deleted the whole part, because it fixed the
bug with the broke link (to an unknown commit), too (done in **lazymode**).

regards,

sandro

_______________________________________________
Devel mailing list
[hidden email]
http://mailman.owncloud.org/mailman/listinfo/devel